[MPlayer-dev-eng] [Patch 1/2] dvd_set_speed fixes/addons

[Sebastian Kemper]

Hello Reimar!

On Sat, Nov 17, 2007 at 01:46:42AM +0100, Reimar Döffinger wrote:
> > - unsigned speed to int speed (because restoring the initial speed means
> >   to set speed=-1)
> 
> Any reason to do the except out of principle? Because then the less
> complex fix is to replace the -1 by ~0 (which is somewhat pointless as well).

I don't think it's _that_ complex ;) And 0 already has a meaning for
dvd_set_speed() (do nothing and exit right away). (Maybe I'm misreading
your ~0, though -- you did mean 0, right?)

> > - use the correct ATAPI command length for SET STREAMING (12 bytes); at
> >   least libata (for now anyways) won't let commands through when the
> >   command length is wrong ("old" ATA is more forgiving and cuts the last
> >   4 bytes)

BTW of course this was the main reason to write the patch at all. See
http://marc.info/?l=linux-kernel&m=119497215212990&w=2

> > - add a check to make sure the device really is an SG device (taken from
> >   sg_simple2.c)
> 
> Why?

You're right. Scrap that.

Regards
Sebastian