[MPlayer-dev-eng] Updated nailfps filter patches

[Rich Felker]

On Mon, Nov 12, 2007 at 10:33:15AM +0100, Guillaume Poirier wrote:
> Hi,
> 
> Reimar Döffinger wrote:
> > Hello,
> > On Sun, Nov 11, 2007 at 05:27:40AM -0500, Christopher Monty Montgomery wrote:
> >> [before anyone complains, there is an exit() to kick out on an error
> >> in the audio filter.  There's no way for an audio filter to return a
> >> fatal error like a video filter can].
> > 
> > There is, in all functions _except_ the play function.
> > And if you really have to do the check in the play function, just print
> > the message each time. Sure, that's not nice for frontends, but no
> > normal user can miss it then...
> > Either way, exit() is not acceptable anywhere in MPlayer (except where
> > it is already used), there is exit_player, but filters have no business
> > using that either.
> 
> 
> Just for curiosity, is it OK to call abort() instead of exit() in
> Christopher's case?

No, it's never okay to abort the program except by returning an error
to the calling code that lets the calling code make the decision to
exit.

Rich