[MPlayer-dev-eng] Updated nailfps filter patches

[xiphmont at xiph.org]

On Nov 12, 2007 4:04 AM,  <xiphmont at xiph.org> wrote:
> On Nov 12, 2007 3:33 AM, Rich Felker <dalias at aerifal.cx> wrote:

> > > +    if(!pipe){
> > >       if(ao_pcm_waveheader && fseek(fp, 0, SEEK_SET) == 0){ /* Write wave header */
> >
> > The if(!pipe) is redundant. fseek will fail on unseekable files. Even
> > if it were useful, it could be merged into the same if...
>
> ...and if you want the pipe behavior on non pipe files?  I'm
> implementing what my doc said I'm implementing.  Could we stick to
> bugs that are actually bugs please.

Oh, and even if the seek fails, you'll get garbage stuck into the
middle of your WAV file when the write happens.

Monty