[MPlayer-dev-eng] Updated nailfps filter patches

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Nov 11 20:14:24 CET 2007


Hello,
On Sun, Nov 11, 2007 at 05:27:40AM -0500, Christopher Monty Montgomery wrote:
> [before anyone complains, there is an exit() to kick out on an error
> in the audio filter.  There's no way for an audio filter to return a
> fatal error like a video filter can].

There is, in all functions _except_ the play function.
And if you really have to do the check in the play function, just print
the message each time. Sure, that's not nice for frontends, but no
normal user can miss it then...
Either way, exit() is not acceptable anywhere in MPlayer (except where
it is already used), there is exit_player, but filters have no business
using that either.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list