[MPlayer-dev-eng] [PATCH] fix numerous const issues in libmpcodecs

Rich Felker dalias at aerifal.cx
Thu Nov 8 12:33:01 CET 2007


On Sun, Oct 21, 2007 at 06:36:59AM -0400, Rich Felker wrote:
> On Fri, Oct 19, 2007 at 05:02:27PM -0400, Rich Felker wrote:
> > On Thu, Oct 18, 2007 at 03:58:34PM -0400, Rich Felker wrote:
> > > MPlayer has LOTS of issues with constant data tables which are not
> > > declared const. While this might or might not have impact on its
> > > memory usage (probably small if any), it's very unclean and makes it
> > > hard to use tools like 'size' to identify modules which are
> > > incorrectly using real global variables instead of per-context data.
> > > 
> > > The attached patch is the initial work towards fixing the problem in
> > > libmpcodecs. I'm submitting it now for comments before I go to lots
> > > more work, only to have someone bitch about why it's bad.. :) So
> > > please comment now. And if anyone would like to volunteer to finish
> > > the job so I don't have to, I'd be quite happy with that too. :))
> > 
> > I realized there was more stuff wrong connected to m_option/m_struct,
> > so before applying the vf changes I'd like to apply the following
> > patch. Objections?
> 
> If no one objects I'll apply this sometime after 24hr.

And I forgot to do that, so I'm threatening to apply again now to give
folks another chance to object. If not, I'll apply soon. I promise
I'll really do it this time.. :)

Rich



More information about the MPlayer-dev-eng mailing list