[MPlayer-dev-eng] [PATCH] mov fragments support for demux_mov

[David Romacho Rosell]

Diego Biurrun wrote:
> On Mon, Oct 29, 2007 at 02:50:12PM +0100, David Romacho Rosell wrote:
>   
>> This is my second attempt to have this patch revised. This patch adds 
>> support for movie fragments in mov files (as specified in the 
>> ISO/IEC-14496). The changes only affect the libmpdemux/demux_mov.c file. 
>>     
>
> Can you point us at some samples for testing?
>
>   
I have a sample which is about 1.5 Mb. How can I make is available to you ?
I have a FTP server where I could create an account just to access that 
file (if that helps)...
>> This feature is not supported by the libavformat demuxer.
>>     
>
> This is unfortunate.  I encourage you to try your hand at adding it to
> the libavformat demuxer, which is better maintained and going to be used
> in the long run.
>
>   
I agree on that, but my spare time is reduced and since I already made 
the effort, I would like to see this feature included first in the 
demux_mov file. As I see, it might take more time that I expected to get 
someone revise the patch, but that's the next point...
>> Regarding the size of the patch, I would like to list all the new features 
>> that this patch adds:
>>     
>
> Is it possible to split this patch into small pieces?  Big patches
> always have a hard time getting committed...
>   

Ok, I will try to send smaller patches that just do a part of the task 
so someone can review them. Would that be better (faster) approach ? I 
just have the code that seem to be working fine and it's the first time 
I participate in an open source project. That's why I sent the patch 
with the complete implementation. As I see, that not the usual method.
> Diego
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>
>   

Sorry for this late replay, I cannot spend as much time as I would like 
to to this.

  David