[MPlayer-dev-eng] [PATCH] simplify decode_audio function

Uoti Urpala uoti.urpala at pp1.inet.fi
Sun Nov 4 13:23:40 CET 2007


On Sun, 2007-11-04 at 12:06 +0100, Reimar Döffinger wrote:
> I think attached patch makes it quite a bit simpler, at least it gets
> rid of an inner loop with exactly the same conditions as the outer loop.
> It should also make more proper EOF/error handling simpler due to having
> only one filter_n_bytes call and thus only one place that must be
> adjusted to that.

I suppose it's OK, though I don't see it as particularly useful or
significant unless you want to do some actual error handling changes
now. If it's changed like that then perhaps the current filter_n_bytes
contents could be moved directly into the loop. They'd probably survive
one extra indent level.




More information about the MPlayer-dev-eng mailing list