[MPlayer-dev-eng] [PATCH] split filter_n_bytes function a bit

[Uoti Urpala]

On Sun, 2007-11-04 at 11:39 +0100, Reimar Döffinger wrote:
> Here I disagree, the current code pretends to check for errors/EOF,
> while it actually only checks if for some reason the decoder didn't
> return any data. Most likely that means EOF or error but not
> necessarily.

Is there some decoder that returns <= 0 except on error/EOF? If there is
then it's broken IMO. There has to be some way to detect error
conditions, and the same values should not occur otherwise and abort
decoding midway. Some (most?) current decoders return 0 on error so the
check cannot be changed to < 0 without changing those.