[MPlayer-dev-eng] [PATCH] split filter_n_bytes function a bit

[Uoti Urpala]

On Sun, 2007-11-04 at 09:45 +0100, Reimar Döffinger wrote:
> I'd consider a dozen lines enough for a function. But I mostly dislike
> that the decoding is hidden within a function that only has "filter" in
> its name. I don't know if it's possible but I'd actually like to get the
> decoding (including eof/error handling) out of there completely, and
> splitting would be a first step.

Then try to find a better name for the current function. The places it's
called from would still use some single name for the overall
functionality (unless you want to replace all the calls with two just to
be able to show two separate function names - I think that would be
silly, and even if that level of explanation was wanted it would be
better done with comments instead of extra function names).

> > Additionally your patch breaks the EOF/error logic.
> 
> I don't see it right now, can you explain?

I read it carelessly and thought it was checking the output len like the
old code. Change "breaks" to "obfuscates".