[MPlayer-dev-eng] [PATCH] dvdsub_id always selectable fix

[Ulion]

2007/11/3, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Nov 03, 2007 at 07:06:02PM +0800, Ulion wrote:
> > 2007/11/3, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > On Sat, Nov 03, 2007 at 02:53:39PM +0800, Ulion wrote:
> > > > I found a bug in mplayer.c about make dvdsub_id always selectable. The
> > > > original code must missed mpctx->global_sub_indices[SUB_SOURCE_DEMUX],
> > > > here's the fix. I will commit it tomorrow if no objects.
> > >
> > > No, I didn't miss it, it was intentional because it was enough to fix
> > > the problem (if you specify external subs that's your own fault ;-) ).
> > > It was still nonsense though, so apply anytime.
> >
> > For Matroska files, external subs possiblly exist both with embedded subs.
>
> This hack should have no relevance for Matroska files. It is only for
> files without proper headers/stream descriptions, which is basically
> MPEG and some DVDs MPlayer "misunderstands".
>

Applied for removing the implicit assumption.

-- 
Ulion