[MPlayer-dev-eng] [PATCH] Fix for vo macosx play window not actived bug on leopard

[Reimar Döffinger]

Hello,
On Sun, Nov 04, 2007 at 01:49:01AM +0800, Ulion wrote:
[...]
> Thank you for reply. Since this is only happens on leopard, so I limit
> the fix only for this os version. Certainly I can ignore the os
> version to call this patch code on all os, that will also work,
> because it's generalized halmless patch code. But I still prefer to
> call the patch code only on leopard.

Introducing special cases means that instead of one code path you now
have two. In the best case each gets tested half as much then. In
reality very soon only one will be used regularly and the other will
bit-rot and break but still be a maintenance burden (since nobody knows
for sure if it still works and someone uses it).
So do not make special cases unless you have _no_ other sane choice.
And in this case: obviously we are doing something different than anyone
else (I doubt Apple would break a huge percentage of all OSX
applications), which most likely means the old code is doing something
_wrong_, and that thing should be found and fixed.

Greetings,
Reimar Döffinger