[MPlayer-dev-eng] [PATCH] Fix for vo macosx play window not actived bug on leopard

Guillaume POIRIER poirierg at gmail.com
Sat Nov 3 17:44:03 CET 2007


Hi,

On 11/3/07, Ulion <ulion2002 at gmail.com> wrote:
> 2007/11/3, Ulion <ulion2002 at gmail.com>:
> > Hello,
> >
> > On Leopard (Mac OS 10.5), vo macosx fail to active the play window
> > after started, on Mac OS 10.4 there's no problem. After test, I found
> > the fail reason is the call makeKeyAndOrderFront failed, probably
> > because on Leopard window can only be actived after NSApp actived, and
> > NSApp actived which need some event stuff work. Since we handle NSApp
> > events in check_events call, if we call makeKeyAndOrderFront once
> > after NSApp actived, will fix the bug. Here's the patch.
>
> I found after application switched, the play window is not actived
> either, so here's the updated patch for it, also detect the running
> os' version to decide whether do special fix.

Do you know if it's possible to generalize the code so that you don't
need to perform different things depending on the OS version?

IMVHO, that would be a better solution, if it exists off course. :)

Guillaume
-- 
A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte



More information about the MPlayer-dev-eng mailing list