[MPlayer-dev-eng] [RFC] emms/sfence in fast memcpy()

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue May 29 09:56:24 CEST 2007


Hello,
On Tue, May 29, 2007 at 01:05:54AM +0300, Ivan Kalvachev wrote:
> 2007/5/28, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> [...]
> > And could someone please explain what the point of that my_memcpy_pic is
> > that is (and worse duplicated) in so many filters??
> 
> Look at the mem2agpcpy_pic() and memcpy_pic() in fastmemcpy.h.
> If both source and destination strides are the same, the functions
> attempt to make the copy in one big move, instead of per-line coping.
> Apparently some filters do not want the extra bytes copied, so they
> implement version that does it correctly.

No if you can also explain why it could be given a proper name and moved
to one place ;-).

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list