[MPlayer-dev-eng] [PATCH] PulseAudio audio output

[Rince]

On 2/22/07, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>
wrote:
>
> Hello,
> On Thu, Feb 22, 2007 at 01:36:37PM +0100, G?tz Waschk wrote:
> > On 7/16/06, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>
> > wrote:
> > >I am not at all a fan of senseless renames I must say. And what kind of
> > >API changes? Will it no longer work with older versions? And how old
> are
> > >the versions it would break?
> > >
> > >> http://0pointer.de/public/mplayer-pulse.patch
> >
> > I'm thinking about adding this to Mandriva's package of MPlayer, it is
> > already in Ubuntu's, but I'd rather have upstream support for
> > pulseaudio in MPlayer. Have you changed your mind yet?
>
> Well, I very personally still the proposed patches are a mess, the new
> API could have been made both simpler and more backwards-compatible
> (e.g. by simply having some functions with an "integrated"
> pa_threaded_mainloop_wait), and the "simple API" should have been called
> "useless API" because there is no "smooth upgrade path" to the full API,
> which in turn seems more like an overcomplicated API.
> There are developers that are less nit-picky than me, but if someone
> wants me to apply this, you (a generic "you", not you personally) really
> have to do some effort of cleaning stuff up, not just throw a patch at me.
>
> Greetings,
> Reimar Döffinger
>

Hi all,

I modified the old PulseAudio patch to apply cleanly against latest SVN
(r23404), and I'm hoping that someone with more time and knowledge of
PulseAudio will clean it up so that it can be pushed upstream. :)

http://rercola.acm.jhu.edu/mplayer-pulse-svn.patch

- Rich