[MPlayer-dev-eng] [PATCH] AF Pitch filter

Guillaume POIRIER poirierg at gmail.com
Mon May 28 10:30:04 CEST 2007


Hi,

On 5/28/07, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> On Mon, May 07, 2007 at 12:01:49AM +0100, Charlie Brej wrote:
> > Index: libaf/kiss_fft.c
> > ===================================================================
> > --- libaf/kiss_fft.c  (revision 0)
> > +++ libaf/kiss_fft.c  (revision 0)
> > @@ -0,0 +1,399 @@
> > +/*
> > +Copyright (c) 2003-2004, Mark Borgerding
> > +
> > +All rights reserved.
> > +
> > +Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
> > +
> > +    * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
> > +    * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
> > +    * Neither the author nor the names of any contributors may be used to endorse or promote products derived from this software without specific prior written permission.
>
>
> Please try to use one of the fft functions in libavcodec, I don't really want
> to waste our time by
> 1) reviewing this code
> 2) finding someone who can tell us if these conditions are compatible
> with the GPL.

Two more things:
3) libavcodec's FFT has already some parts optimized with
MMX/SSE/Altivec, so we don't really want to duplicate this effort.
4) Now that you proved that your pitch filter works with an FFT that
you know how to use, it shouldn't be too hard to port it to lavc's,
which is also supposed to work, though U ca

-- 
Y'a pas de gonzesse hooligan,
Imbécile et meurtrière
Y'en a pas même en grande Bretagne
A part bien sûr Madame Thatcher
  -- Renaud (sur "Miss Maggie")


More information about the MPlayer-dev-eng mailing list