[MPlayer-dev-eng] RFC conformance for stream/rtp.c (on 64 bit platforms)
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun May 27 11:12:52 CEST 2007
Hello,
On Sun, May 27, 2007 at 06:21:47AM +0300, Bogdan Mustiata wrote:
> Conforming to RFC1889 (RTP: A Transport Protocol for Real-Time Applications),
> the RTP header should be 4 byte aligned. Unfortunately, in stream/rtp.c,
> ints are used to define the RTP header and they are not allways 4 byte as
> assumed in that code on 64bit platforms.
Actually int is quite certainly always 4 bytes.
> This patch changes the int usage to the reliable uint32_t and int32_t types.
Cleaning up that mess to not use structs at all to pack the data -
possibly by moving bitstream functions from libavcodec to libavutil and
using those - would make a lot more sense IMO.
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list