[MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work on AMD64, Part 5
gpoirier at mplayerhq.hu
Fri May 25 14:06:11 CEST 2007
Reimar Döffinger wrote:
> On Fri, May 25, 2007 at 02:14:49PM +0800, Zuxy Meng wrote:
>> We've reached Part 5. This is again a big diff, replacing many 'long'
>> to 'int', and several 'real' to 'short'. Among those, many are
>> necessary because under LP64 environment, sizeof(long) != sizeof(int)
>> and sizeof(long) != sizeof(float); others are optimizations simply
>> because we really don't need such a long type, or the declaration
>> didn't match its use (declared as float, used as short).
> These are separate issues and should be fixed in different patches. Also
> if you changed long to int because the code assumes 32 bits, it would
> make more sense to change it to int32_t. Replacing long with int without
> thinking can make the code even slower on 64 bit systems.
> This is unrelated and also completely useless since a static function
> that is used in only one place will be inlined anyway.
> In addition it is wrong since "static void make_decode_tables()" !=
> "static void make_decode_tables(void)"
Thanks for your quality review Reimar! I realize I'm quite a lousy
reviewer, but I'm trying to do my best! :-(
More information about the MPlayer-dev-eng