[MPlayer-dev-eng] [PATCH] blue back tv feature (automute with no signal)

[Alban Bedel]

On Fri, 25 May 2007 09:30:43 +0300
Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:

> On Fri, 2007-05-25 at 13:12 +0700, Vladimir Voroshilov wrote:
> > In such case first solution will be better, i think.
> > It is not difficult for me to add something like
> > "tv_is_signal_present" and check it in main loop together with
> > DEMUXER_TYPE_TV. If this is the only solution with current design,
> > i'll do so. I just need a point where to put such check in main loop.

No, you should use a control, not some demuxer specific code. Which make
me think a GET_OSD_MSG control would be best suited. It would be quiet
close to what you originaly wanted and it could also become useful for
some other things.

> Does the demuxer generate some kind of (empty) frames even when there's
> no signal? The OSD is currently only updated when a new frame is drawn.
> If there are no video frames then more mainloop changes are required.

Yep, however imho we should avoid that as much as possible. For the no
signal case it would be much simpler to simply send frames at some low
fps. And with some clever use of packet dup it should be possible to
avoid memsetting each frame.

> If there are frames then I think the architecturally best choice would
> be to mark the information in the demuxer packet and check that in the
> main loop when reading the packet. Implementing this requires some extra
> work though because currently the only extra information in addition to
> frame data that is read in the main loop is timestamps, and those are
> passed in separate parameters.

Generaly speaking alowing extra info on demuxer packets could be good.
However if those info are too specific we get again some demuxer specific
code in the main loop wich is a bad thing.

> Another alternative would be to return frames which contain the "no
> signal" text as the picture instead of using OSD.

I thought about that too but then real font drawing would be needed
for translations. So imho that's a no no.

	Albeu