[MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work on AMD64, Part 4

[Guillaume Poirier]

Hi,

Zuxy Meng wrote:
> Hi,
> 
> 2007/5/23, Guillaume Poirier <gpoirier at mplayerhq.hu>:
>> Zuxy Meng wrote:
>>> I guess this approach causes least trouble.
>> Looks Ok to me. Once it's committed, please do explain where these
>> magic values come from by putting  doxygen-like comment on top of the
>> new array, referring to the commit just just made (please also add the
>> revision number), pointing out that the values are essentially always
>> the same no matter the input file.
> 
> How about this?
> 
> /**
>   This array of magic numbers were calculated by the pure function
>   make_decode_tables_MMX(32768), which had been implemented in (now deleted)
>   tabinit_MMX.c, r21060.
>   */
> static short __attribute__((aligned(8))) mp3lib_decwins[] =



Just one nitpick:

... which had been implemented in (deleted since rXXX) ...

that way there's no problem finding the patch you are about to commit.
Since you can't "really" know the revision number until you make the
commit, feel free to split it in 2 patches.

Otherwise it's fine.

Guillaume