[MPlayer-dev-eng] gCpuCaps and dsp_mask?

Zuxy Meng zuxy.meng at gmail.com
Tue May 22 11:58:44 CEST 2007


Hi,

Although mplayer checks OS support of SSE and set gCpuCaps.hasSSE to
zero if such check fails, libavcodec doesn't know this and continue to
use SSE/SSE2 accelerations as long as the CPU reports them in cpuid.
Nowadays virtually all OSes provide SSE support so it seldom causes
problem, but do it 'correctly' we should mask out SSE/SSE2 in
AVContext->dsp_mask if gCpuCaps->hasSSE == 0.

The problem is that we'll need to do it in several places
(ad_ffmpeg.c, vd_ffmpeg.c, ae_lavc.c, ve_lavc.c). Where's the proper
place to put the code?

Or we can leave things as is. Anyway I guess the OS checking is quite
redundant as SSE has appeared for about 10 years.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list