[MPlayer-dev-eng] [PATCH] fix for v4l1 driver

[Vladimir Voroshilov]

2007/4/29, Trent Piepho <xyzzy at speakeasy.org>:
> On Sun, 29 Apr 2007, Vladimir Voroshilov wrote:
> > 2007/4/28, Trent Piepho <xyzzy at speakeasy.org>:
> >
> > >@@ -798,6 +770,53 @@
> > >     if (ioctl(priv->video_fd, VIDIOCSPICT, &priv->picture) == -1)
> > >     {
> > >     mp_msg(MSGT_TV, MSGL_ERR, "ioctl set picture failed: %s\n", strerror(errno));
> > >+    mp_msg(MSGT_TV, MSGL_ERR, "The 'outfmt' of '%s' is likely not
> > supported by your card\n",
> > >+           vo_format_name(priv->format));
> > >+    return 0;
> >
> > Why don't you change existing message?
> > Other parts looks ok for for me at quick-look.
>
> It seemed like the existing message was still relevant, since it says what
> ioctl failed and the error code.
>
> >
> > In another cosmetics patch you also change comment in disabled block of
> > code.
> > Can i know the reason for it ?
>
> I thought it was a call to VIDIOSCAPTURE instead of VIDIOCCAPTURE, but it's
> not so I've taken that change out.
>
> I see you pulled the typo fix out of my patch and put in already, so I won't
> include that again in my patch.

since no objections received, patch applied.
Thanks for your work.


-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719