[MPlayer-dev-eng] RFC on libspe2 detection
Luca Barbato
lu_zero at gentoo.org
Thu May 17 09:42:58 CEST 2007
Rasmus Rohde wrote:
[patch]
here some nits:
- avoid unnecessary casts
- why are you favoring the usage of the external program instead of the
embedded one? shouldn't be the opposite? (you fallback to the external
program only if you hadn't embedded the spu code?)
- shouldn't first set up the handler and then, if everything is fine,
spawn the new thread?
- you could factorize some constants
- please have your code formatted to 97 col bound otherwise is a bit
harder to read.
lu
--
Luca Barbato
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero
More information about the MPlayer-dev-eng
mailing list