[MPlayer-dev-eng] [PATCH] Display blanking prevention for maemo (Nokia 770/N800)

[Rich Felker]

On Sun, May 13, 2007 at 08:06:22PM +0300, Siarhei Siamashka wrote:
> On Sunday 13 May 2007 19:35, Rich Felker wrote:
> > On Sun, May 13, 2007 at 07:30:47PM +0300, Siarhei Siamashka wrote:
> > > This patch adds display blanking prevention which is very important for
> > > video playback on Nokia internet tablets. Power management turns display
> > > off after some time of inactivity to save battery. But when the user is
> > > watching video, this behaviour is undesirable and very annoying (to the
> > > point of making video player unusable).
> > >
> > > This is the final revision of the code which now successfully works on
> > > both Nokia 770 and Nokia N800 [1] and hopefully will work properly on any
> > > other maemo devices that might be released in the future.
> > >
> > > 1. https://garage.maemo.org/projects/mplayer/
> >
> > This code belongs in the relevant vo module, not mplayer.c
> 
> Blanking prevention needs to be used with any vo module. It is more related
> to power management, but not video output directly. Relevant vo modules are:
> xv, x11, sdl, nokia770 (custom framebuffer based module)
> 
> Alternative solution would need to have all of them patched, which is a lot
> uglier and needs more lines of code. I agree that mplayer.c contains too 
> much code already, but I don't see anything better (except for moving all the
> screensaver related stuff to some other file). Thoughts?

If the nokia 770 uses X, then the X server needs to be fixed to do
this blanking-prevention based on the status of the X server's
screensaver. It's not acceptable to fill every application with
hardware-specific hacks like this. It's a necessary part of a correct
driver for the nokia 770's video hardware...

Rich