[MPlayer-dev-eng] [PATCH 1/3] make lavc dv encoding work in mencoder

[Michael Niedermayer]

Hi

On Sat, May 12, 2007 at 04:23:14PM -0700, Corey Hickey wrote:
> Corey Hickey wrote:
> > Hello,
> > 
> > This set of small patches makes lavf DV muxing work in mencoder... at
> > least, pretty well. If you don't get the video and audio parameters to
> > match one of the supported DV profiles, lavf will output an error and
> > mencoder will SIGFPE. I wanted to send in what I have so far, though;
> > fixing the SIGFPE will require unrelated work.
> 
> This makes ve_lavc provide a valid DV fourcc "dvsd". Without the patch,
> lavc gets a fourcc of "dvvi" (see the FIXME line at the end of the patch).
> 
> -Corey

> Index: libmpcodecs/ve_lavc.c
> ===================================================================
> --- libmpcodecs/ve_lavc.c	(revision 23299)
> +++ libmpcodecs/ve_lavc.c	(working copy)
> @@ -991,6 +992,8 @@
>  	mux_v->bih->biCompression = mmioFOURCC('S', 'N', 'O', 'W');
>      else if (!strcasecmp(lavc_param_vcodec, "flv"))
>  	mux_v->bih->biCompression = mmioFOURCC('F', 'L', 'V', '1');
> +    else if (!strcasecmp(lavc_param_vcodec, "dvvideo"))
> +	mux_v->bih->biCompression = mmioFOURCC('d', 'v', 's', 'd');
>      else
>  	mux_v->bih->biCompression = mmioFOURCC(lavc_param_vcodec[0],
>  		lavc_param_vcodec[1], lavc_param_vcodec[2], lavc_param_vcodec[3]); /* FIXME!!! */


shouldnt the fallback rather use mp_bmp_tags ?

and iam ok with the patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070513/737d08f0/attachment.pgp>