[MPlayer-dev-eng] [PATCH] avoid code duplication for fourcc/extradata setting in demux_mkv.c

[Uoti Urpala]

On Wed, 2007-05-09 at 23:21 +0200, Reimar Döffinger wrote:
> Hello,
> On Wed, May 09, 2007 at 11:58:35PM +0300, Uoti Urpala wrote:
> > On Wed, 2007-05-09 at 22:04 +0200, Reimar Döffinger wrote:
> > > I will reindent the MSGTR_MPDEMUX_MKV_UnknownCodecID block in a separate
> > > commit.
> > 
> > Why? Just to litter the log with meaningless commits? The diff doesn't
> > match it even if it's on the same level. And even if it was matched it
> > still wouldn't be worth adding an extra commit.
> 
> That is your opinion, not mine and I don't intend to discuss this
> subject, that has been done often enough you know my opinion.

Whether matching some trivial lines of code in the diff is worth making
an extra commit and leaving the first committed version incorrectly
indented can perhaps be called a matter of opinion. But if the lines
don't match in the diff anyway despite being left at the now incorrect
level then still doing it just doesn't make sense.