[MPlayer-dev-eng] [PATCH] avoid code duplication for fourcc/extradata setting in demux_mkv.c

[Moritz Bunkus]

Hey,

On Wednesday 09 May 2007 22:04, Reimar Döffinger wrote:

> attached patch also allows to add theora support by adding just one line
> instead of copy-and-paste of the whole extradata handling.
> Objections? Suggestions for improvements?
> I will reindent the MSGTR_MPDEMUX_MKV_UnknownCodecID block in a separate
> commit.

Nice, I like it. You can also just add Theora support while you're at it
(assuming that mplayer's Theora decoder supports Matroska's CodecPrivate
style extradata -- I simply don't know, but I guess you've already
tried).

The patch itself looks correct. Please apply.

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070509/44454427/attachment.pgp>