[MPlayer-dev-eng] [PATCH] Equals in Ogg comments
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue May 8 21:49:43 CEST 2007
Hello,
On Tue, May 08, 2007 at 02:04:17PM +0200, Nicolas George wrote:
> [ Previously in this thread:
> If an Ogg file has commments "title=Foo" and "title_bar=Foo-unreadable",
> mplayer will print "Title: _bar=Foo-unreadable" instead of "Title: Foo".
> ]
>
> Le quintidi 15 ventôse, an CCXV, Nicolas George a écrit :
> <snip>
>
> Sorry, but has been two months, and the bug is still there. Here is the
> patch, updated to current SVN (there was nothing to update, in fact).
>
> As Reimar Döffinger pointed out, the same goal could have been achieved by
> adding '=' in table[i].name, but I find it a little bit more logical that
> way.
>
> Regards,
>
> --
> Nicolas George
>
>
> Index: libmpdemux/demux_ogg.c
> ===================================================================
> --- libmpdemux/demux_ogg.c (revision 23261)
> +++ libmpdemux/demux_ogg.c (working copy)
> @@ -455,7 +455,8 @@
> else {
> for (i = 0; table[i].ogg; i++)
> {
> - if (!strncasecmp(*cmt, table[i].ogg, strlen(table[i].ogg)))
> + if (!strncasecmp(*cmt, table[i].ogg, strlen(table[i].ogg)) &&
> + (*cmt)[strlen(table[i].ogg)] == '=')
> {
> hdr = table[i].mp;
> val = *cmt + strlen(table[i].ogg) + 1;
I think it is okay, but I did not even test. I CC the demux_ogg
maintainer.
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list