[MPlayer-dev-eng] [PATCH] libmenu subtitles selector

[Alban Bedel]

On Tue, 08 May 2007 12:11:54 +0200
Benjamin Zores <ben at geexbox.org> wrote:

> Have a look at 
> http://hg.geexbox.org/geexbox-mplayer-current/file/d2822555a416/packages/MPlayer/patches/515_menu-audio-sub-chap.diff

Thanks.
 
> This patch file may not exactly work/apply as it and i intended to have 
> it commited in multiple parts (i sent first one) but first, give me your 
> feeling about it.

The basic idea (having a/v/sid selection) is fine, but to be honest it's
exactly the kind of implementation i wanted to avoid from the start.
It's too tied to the internal of the current track selection, partialy
duplicating code wich as Nico said is very messy.

> You wanna work on libmenu again to extend it another way ?

It so happend i was recently reviving an old patch of mine (audio
visualisation with goom :) and it got me back again in hacking
mplayer.
One idea i had would be to allow menu generated from script and/or
loaded at runtime. Thus allowing frontends to do things like
autodetecting what media is in a drive (cdda, vcd, dvd, etc) and
then showing the right menu. Currently just an idea but i think
it might be worth exploring.
Another thing i had in mind was to perhaps add a basic mouse support.

> I have no objections to that and can help you in this way.

Currently i'm working on the metadata stuff wich is imho too limited.
What i'd like is a nice integration with the rest of the properties
API. I did a quick hack last night but it still need some work.

Incidently this stuff is not very far from what is needed for track
selection. In both case we need acces a list of key/value, it's just
the value type that change. For metadata a string as value is enouth,
but for tracks we probably want a more complete description wich
include stuff like the language, etc.

> What I need for GeeXboX (to avoid having some much patches to maintain 
> each time we upgrade MPlayer) is a possibility to select and switch 
> aid/sid/chapters from OSD menu.

Track selection shouldn't be a problem thanks to the recent work that
went in cleaning the player core. However chapter (and stream stuff
in general) is probably still not easy. The biggest obstacle is the
cache which make it near to impossible to reliably use control on the
stream at run time. There are solutions but they are either, hard to
implement in a nice and portable way (IPC), or are going to be hard to
get accepted by everybody (using threads for the cache).

	Albeu