[MPlayer-dev-eng] [PATCH] libmenu subtitles selector

[Alban Bedel]

On Tue, 8 May 2007 01:01:35 +0200
Alban Bedel <albeu at free.fr> wrote:

> On Tue, 08 May 2007 00:37:08 +0200
> Benjamin Zores <ben at geexbox.org> wrote:
> 
> > Hi,
> > 
> > Attached patch adds a new subtitle selector menu to libmenu.
> > It currently only works with DVDs, though it'll be extended to handle 
> > Ogg and Matroska in a near future.
> > 
> > The /etc/menu.conf sample will be extended afterwards, but to test it 
> > you need to add:
> > <subsel name="sub_sel" title="Select subtitle"/>
> > <e name="Subtitle selection ..." ok="set_menu sub_sel"/>
> > 
> > Ok to apply ? (Alban ? ;-))
> 
> I'm wondering what the point is, isn't the preference menu enouth ?
> If not i would prefer to see a generic solution, that will also
> do for audio and video.

To be more explicit, a cleaner solution would be to add a new property
control to get the list of choice from the current sub property. This
way it could be used for all properties that give a list of choice.
Yeah, i hate too specfic code that could very easily be generic :)

	Albeu

PS: Could you post all the pending patch at once (or at least a short
    description), not for real review but to get an overall look as
    i'm planning a few stuff myself (like making that metadata stuff
    beeing able to use any meta instead of a selected list).