[MPlayer-dev-eng] [PATCH] Optimized libmpeg2 routines for ARM/Xscale

[Siarhei Siamashka]

On Monday 07 May 2007 15:17, Guillaume POIRIER wrote:

> On 5/5/07, Guillaume POIRIER <poirierg at gmail.com> wrote:
> > Hi there,
> >
> > Attached patch features $SUBJ. It's just a re post of a patch posted
> > by David Bateman while I was on hollidays, but never made it to SVN.
> > It was advised to send these changes to libmpeg2 team directly, but
> > since this project hasn't even acknowledged the message, I plan to
> > apply attached patch in a few days.
>
> No objection? I'll apply it tonite unless there's ojection since then.

This patch breaks compilation:

motion_comp.c: In function `mpeg2_mc_init':
motion_comp.c:71: error: `MPEG2_ACCEL_ARM' undeclared (first use in this 
function)
motion_comp.c:71: error: (Each undeclared identifier is reported only once
motion_comp.c:71: error: for each function it appears in.)

These MPEG2_ACCEL_ARM and MPEG2_ACCEL_ARM_IWMMXT are not 
defined anywhere.

In addition, there is a problem with PLD (cache prefetch) instruction, it is
only available on ARMv5TE, but this code is also getting compiled in when
configured for ARMv4. The same problem exists in ffmpeg as well, and it 
was raised on ffmpeg-devel mailing list recently.

Other than that, I don't have any ARM device with IWMMXT support to test (only
have Nokia 770 and N800 here), so can't provide further feedback regarding
IWMMXT code.

Would you like to have ARMv5 optimizations [1] merged in MPlayer as well?
I was not sure if it would be a good idea to submit them to MPlayer instead of
upstream libmpeg2, so did not try that earlier.

1. 
https://garage.maemo.org/plugins/scmsvn/viewcvs.php/trunk/libmpeg2/?root=mplayer