[MPlayer-dev-eng] Gui testing on bigendian

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun May 6 20:20:57 CEST 2007


Hello,
On Sun, May 06, 2007 at 08:09:29PM +0200, Diego Biurrun wrote:
> On Sun, May 06, 2007 at 02:57:40PM +0200, Reimar Döffinger wrote:
> > can somebody please test current SVN (and maybe also older versions) of
> > the Gui against the 'Blue' skin and tell me how it looks like?
> > It seems I broke displaying 32bit png images with the change to
> > libavcodec PNG decoder, and while I know the correct fix for
> > little-endian, all ideas I have for big endian would mean that the old
> > code can't have worked (esp. the use of swab() I just can't make sense
> > of)...
> 
> It looks funky indeed :)
> 
> Let me know of any precise tests you want me to do.

Well, most importantly if it looked alright with libpng, then which
colours get replaced by which, and lastly try
> memmove(bf->Image, bf->Image + 1, bf->ImageSize - 1);
before, after or instead of the swab() in gui/bitmap.c, line 160.
Alternatively, if someone fixes the old code using libpng to work for
remote X with differing endianness I could check myself ;-)

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list