[MPlayer-dev-eng] add -Wall to default CFLAGS

[Thomas Orgis]

Am Sat, 5 May 2007 04:12:56 -0400
schrieb Rich Felker <dalias at aerifal.cx>: 

> On Sat, May 05, 2007 at 12:34:49AM -0600, Sven Gothel wrote:

> > And forget all about this 'long long' - you never know what you get - types.
> 
> This is stupid. [u]intXX_t types are for when you need exactly a
> specific size, e.g. for arrays of samples that need to be in a

Generally I agree that one only should use exactly sized types when
one really needs that exact type and otherwise stick with the flexible
system-dependend types. But actually, this is one of the special cases;
the long long values are constants that are used in assembler code later:

static unsigned long long attribute_used __attribute__((aligned(8))) null_one = 0x0000ffff0000ffffULL;
static unsigned long long attribute_used __attribute__((aligned(8))) one_null = 0xffff0000ffff0000ULL;

I think I'll move this all back into standalone assembler anyway (to match
rest of mpg123 code)...


Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070505/1b33129c/attachment.pgp>