[MPlayer-dev-eng] r23172 - in trunk/gui: interface.c mplayer/common.c mplayer/gtk/eq.c mplayer/gtk/menu.c mplayer/gtk/opts.c mplayer/gtk/url.c mplayer/menu.c mplayer/mw.c mplayer/sw.c

[SciFi]

On Sun, 29 Apr 2007 23:15:17 +0200, Reimar Döffinger wrote:

> Hello,
> On Sun, Apr 29, 2007 at 08:24:52PM +0000, SciFi wrote: [...]
>> In file included from interface.c:52: ../stream/vcd_read.h:243:2:
>> error: #error vcd is not yet supported on this arch... interface.c: In
>> function ???gconvert_uri_to_filename???: interface.c:201: warning:
>> passing argument 2 of ???libiconv??? from incompatible pointer type
>> interface.c: In function ???guiInit???: interface.c:319: warning:
>> pointer targets in passing argument 2 of ???wsConvert??? differ in
>> signedness interface.c: In function ???guiGetEvent???: interface.c:660:
>> warning: implicit declaration of function ???vcd_seek_to_track???
>> make[1]: *** [interface.o] Error 1
>> make[1]: Leaving directory
>> `/Volumes/IBMama/Projects/svn.mplayerhq.hu/mplayer/gui' make: ***
>> [gui/libgui.a] Error 2
>> make: Leaving directory
>> `/Volumes/IBMama/Projects/svn.mplayerhq.hu/mplayer'
> 
> Are you really using the GTK Gui under OSX? Nobody is testing that and I
> doubt someone will be fixing the Gui too soon to build again on OSX, the
> linux fixes already always take ages... As a quick hack you can try
> including vcd_read_darwin.h instead of vcd_read.h
> 
> Greetings,
> Reimar Döffinger

I'm going to back-up then keep a copy of interface.c applied with
r23172, i.e. to effectively not get the r23176 reversion of
r23172, so I can test this further.

Indeed altering r23172 to include vcd_read_darwin.h instead will
allow it to compile.  Now I need to find some [S]VCDs in storage
somewhere 'round here to see if [g]mplayer can actually play them
interactively.  ;)

Of course this isn't going to fix other platforms w/r/t r23172,
they _will_ need r23176 for the time being, but I'd really like to
find out on my own if this will work with darwin/osx here.

I now remember vcd_read_darwin.h might also give us a clue how to
update the libdvd* stuff to have some native support (I remember
bringing this up about 6 months ago, some old neurons got excited
on remembering this again again ;) ).

Thanks...