[MPlayer-dev-eng] [PATCH] Add surround50 to autodetected devices

[Piotr Kaczuba]

Clemens Ladisch napisał(a):
[...]
> Apart from the missing Changelog entry, the patch itself looks OK.
> 
> However, a five-channel audio file could have LFE as the fifth channel;
> in that case, "surround41" would be the correct device to use.
Yes, I noticed this, too. I don't know if 4.1 or 5.0 files are more common,
though.

> The driver should select "surround41" or "surround50" depending on the
> type of the fifth channel, but the current libao2 API doesn't allow to
> detect this.
> 
> It would be possible to add a flag to the ao init() function, but this
> would also require to change most audio demuxers to actually provide
> this information, and if a demuxer doesn't know, we'd still have to
> guess.
Indeed, retrieving the information from the demuxer would be the best
thing to do. I don't know if it's realistic to assume that all of the
demuxers will be changed. If not, maybe using one fixed device depending
on whether 4.1 or 5.0 are more common would be sufficient. Additionally,
a message could be displayed to the user that the guess may be wrong.

Piotr