[MPlayer-dev-eng] [PATCH] fix resources in mingw build

Gianluigi Tiesi mplayer at netfarm.it
Tue Mar 27 06:02:16 CEST 2007


On Tue, Mar 27, 2007 at 05:38:44AM +0200, Gianluigi Tiesi wrote:
> The var is clobbered by
> 
> OBJS_MPLAYER  = $(SRCS_MPLAYER:.c=.o)
> 
> so I think it should be changed to
> 
> OBJS_COMMON   += $(SRCS_COMMON:.c=.o)
> OBJS_MPLAYER  += $(SRCS_MPLAYER:.c=.o)
> OBJS_MENCODER += $(SRCS_MENCODER:.c=.o)
> 
> Bye
> 
Sorry for spamming, attached patch should be the better way to handle
the problem, += on OBJS breaks somehow version.h creation

Bye
-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/
-------------- next part --------------
Index: Makefile
===================================================================
--- Makefile	(revision 22832)
+++ Makefile	(working copy)
@@ -91,16 +91,17 @@
 ALL_PRG-$(MENCODER) += mencoder$(EXESUF)
 
 SRCS_COMMON  += $(SRCS_COMMON-yes)
+
+OBJS_COMMON   = $(SRCS_COMMON:.c=.o)
+OBJS_MPLAYER  = $(SRCS_MPLAYER:.c=.o)
+OBJS_MENCODER = $(SRCS_MENCODER:.c=.o)
+
 COMMON_LIBS  += $(COMMON_LIBS-yes)
 LIBS_MPLAYER += $(LIBS_MPLAYER-yes)
 OBJS_MPLAYER += $(OBJS_MPLAYER-yes)
 PARTS        += $(PARTS-yes)
 ALL_PRG      += $(ALL_PRG-yes)
 
-OBJS_COMMON   = $(SRCS_COMMON:.c=.o)
-OBJS_MPLAYER  = $(SRCS_MPLAYER:.c=.o)
-OBJS_MENCODER = $(SRCS_MENCODER:.c=.o)
-
 COMMON_LIBS += osdep/libosdep.a
 
 MPLAYER_DEPS  = $(OBJS_MPLAYER)  $(OBJS_COMMON) $(LIBS_MPLAYER)  $(COMMON_LIBS)


More information about the MPlayer-dev-eng mailing list