[MPlayer-dev-eng] [PATCH] fix resources in mingw build

[Gianluigi Tiesi]

On Sat, Mar 24, 2007 at 05:28:14PM +0100, Diego Biurrun wrote:
> On Sat, Mar 24, 2007 at 03:57:50PM +0100, Diego Biurrun wrote:
> > On Sat, Mar 24, 2007 at 03:52:41PM +0100, Gianluigi Tiesi wrote:
> > > On Sat, Mar 24, 2007 at 02:05:31PM +0100, Diego Biurrun wrote:
> > > > On Sat, Mar 24, 2007 at 02:05:09AM +0100, Gianluigi Tiesi wrote:
> > > > > 
> > > > > OBJS_MPLAYER-$(TARGET_WIN32) += osdep/mplayer-rc.o
> > > > > 
> > > > > doesn't work anymore for me,
> > > > > Also resource file is a bit outdated.
> > > > > 
> > > > > The patch adds resources to mplayer/mencoder by using ifeq
> > > > > and also updates a bit the resource file (rc).
> > > > > 
> > > > > --- Makefile	(revision 22787)
> > > > > +++ Makefile	(working copy)
> > > > > @@ -129,7 +129,10 @@
> > > > >  
> > > > >  # Having this in libosdep.a is not enough.
> > > > > -OBJS_MPLAYER-$(TARGET_WIN32) += osdep/mplayer-rc.o
> > > > > +ifeq ($(TARGET_WIN32),yes)
> > > > > +	OBJS_MPLAYER += osdep/mplayer-rc.o
> > > > > +	OBJS_MENCODER += osdep/mplayer-rc.o
> > > > > +endif
> > > > 
> > > > That's the wrong fix.  Also, why do you wish to use it for MEncoder as
> > > > well?  Note that I'm not fully sure what this file is used for in the
> > > > Windows build.
> > > > 
> > > Because I want to use the resource both on mplayer and mencoder.
> > 
> > Why?  What is it good for?
> > 
> > > old way using OBJS_MPLAYER-$(TARGET_WIN32) doesn't work anymore for me.
> > 
> > Try moving it from line 132 to line 120.
> 
> I've moved it, this was obviously wrong, your problem should be gone.
> 
It doesn't work and it's very strange, to be honest I was already tried
this without success.

I've temp changed "all" target to show some vars:

OBJS_MPLAYER: mplayer.o m_property.o mp_msg.o mixer.o parser-mpcmd.o subopt-helper.o command.o
OBJS_MPLAYER-yes: osdep/mplayer-rc-rc.o
OBJS_MPLAYER TARGET_WIN32: OBJS_MPLAYER-yes

it seams that:
OBJS_MPLAYER += $(OBJS_MPLAYER-yes)

doesn't work on mingw make
Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/