[MPlayer-dev-eng] Re: [PATCH] TV teletext

[Alban Bedel]

On Sun, 25 Mar 2007 19:52:26 +0700
"Vladimir Voroshilov" <voroshil at gmail.com> wrote:

> 2007/3/25, Alban Bedel <albeu at free.fr>:
> > On Thu, 22 Mar 2007 15:59:45 +0600
> > "Vladimir Voroshilov" <voroshil at gmail.com> wrote:
> >
> > > What are these mp_property_* used for ?
> > > Why do you define  vbi_* as properties if you define vbi_* slave commands
> > > later.
> >
> > Using properties is good, it allow interfacing with the osd menu (and the
> > GUI perhaps someday). However the commands are indeed useless, one can
> > just send a set_property command instead. All those commands directly
> > mapping to properties are there for backward compatibility. Idealy
> > they should just be removed but currently it would probably break many
> > frontends.
> So Otvos should name his properties well (e.g.  "teletext_page"
> instead of "vbi_page_step") and bind commands to "step_property
> teletext_page 1"
> instead of "vbi_step_page 1". Am i right?

Yes, although i don't care about the name.

	Albeu