[MPlayer-dev-eng] [PATCH] Remove leading/trailing margin for VCD

[Zuxy Meng]

Hi,

2007/3/22, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> from docs/vcdimager.texi:
>
> "
> @item
> Up to 98 @acronym{MPEG} mode 2 form 2 tracks wrapped in front and rear
> margin at footnote{Margins seem to be used, in order to compensate for
> inaccurate sector addressing issues on @acronym{CD-ROM}
> media. Interestingly, they have been abandoned for the Super Video
> CD.} empty sectors and preceded by (at least) 150 empty sector
> pre-gaps."
>
> it doesn't say that
> so I'd say that
>  for (tmp = sect; tmp < sect + 3 * 75; tmp++) {
>    char mem[VCD_SECTOR_DATA];
>    if (vcd_read(vcd, mem) != VCD_SECTOR_DATA || mem[2] != 0 || mem[3]
> != 0)
>     break;
>  }
>
> is safer, but why that last
> vcd_set_msf(vcd, tmp); ?

Without that line, the next vcd_read() will read the second valid
sector of a track, not the first one:-)

> The rest is fine for me, but without that if-0 code

OK
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6