[MPlayer-dev-eng] Re: [PATCH] Extradata handling for X-QT over rtsp

[Nico Sabbi]

Carl Eugen Hoyos wrote:
> Nico Sabbi <nicola_sabbi <at> fastwebnet.it> writes:
> 
> 
>>>Attached patch makes extradata handling for X-QT over rtsp slightly more
>>>correct.
>>
>>eplain it, please
> 
> 
> Atm, if, for example, an AVC stream contains an "esds" atom, or SVQ3 an "avcC"
> atom, the code will (IMO wrongly) insert this incorrect atom behind bih. The
> change would only copy correct atoms for the respective fourcc's.

there's a basic misunderstanding on this subject:
esds stands for "elementary stream descriptor" in mov parlance,
so it applies to every possible codec, not only to mp4v
(and not even only to aac as demux_mov.c seems to believe),
so an esds may contain extradata for whichever codec used.


> 
> Second change is that needVideoFrameRate() would be called for every quicktime
> rtsp stream, wich is correct: Other fourcc's than mp4v, SVQ3 and avc1 might play
> without extradata (as mp4v and SVQ3 do at least for some samples).
> 
> Carl Eugen

I don't see this change

-- 
"Without a frontend, mplayer is useless" - someone in mplayer-users