[MPlayer-dev-eng] Re: libdvdnav

[Ötvös Attila]

2007. március 15. 12.03 dátummal Diego Biurrun ezt írta:
Hi Diego Biurrun!
> > --- configure	 (revision 22547)
> > +++ configure	 (working copy)
> > @@ -5181,15 +5199,32 @@
> > +  _def_dvdnav_sversion="#define DVDNAVSVERSION \"0.1.10\""
>
> What's 'sversion' supposed to be?  Please find a more descriptive
> variable name.
>
> > --- dvdnav/Makefile	 (none)
> > +++ dvdnav/Makefile	 (working copy)
> > @@ -0,0 +1,22 @@
> > +
> > +SRCS_COMMON += decoder.c \
> > +       dvdnav.c \
> > +       highlight.c \
> > +       navigation.c \
> > +       read_cache.c \
> > +       remap.c \
> > +       searching.c \
> > +       settings.c \
> > +       vm.c \
> > +       vmcmd.c \
>
> Please align the sources.
>
> > +CFLAGS = -I. -I.. -I../loader -DHAVE_CONFIG_H
>
> Are all of these really needed?  -I. and -I.. are in the default CFLAGS.
>
> > +ifeq ($(DVDREAD_INTERNAL),yes)
> > +INCLUDE += -I../dvdread -I../../dvdread
> > +endif
>
> There is no such thing as an INCLUDE variable, this is likely broken and
> your intention was to add this to the CFLAGS.  Use
>
>   CLAGS-($(DVDREAD_INTERNAL) += -I../dvdread -I../../dvdread
>
> instead to achieve this, but do you need both ../ and ../../ ?

I correctioned this.

Best regard!
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3-libdvdnav-with_mplayer.patch
Type: text/x-diff
Size: 9226 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070315/278fd18a/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3-libmpdvdnav.patch
Type: text/x-diff
Size: 7896 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070315/278fd18a/attachment-0001.patch>