[MPlayer-dev-eng] [PATCH] VCD support for Windows (except Win9x)

[Uoti Urpala]

On Mon, 2007-03-12 at 18:44 +0100, Diego Biurrun wrote:
> Benjamin, never split patches by file or directory.  Commits should be
> logical units.  If a patch can be split *logically* into smaller pieces,
> then it's fine and even beneficial to spread them over multiple commits.
> Otherwise maintain the parts together.
> 
> It's quite possible that some revisions don't compile anymore now.
> 
> You could undo and recommit this now, but, to be honest, I don't much
> care.

Undoing it (or any similar case) would be pointless and somewhat harmful
IMO. The current code works (at least I suppose so, haven't checked).
Recommitting would not remove any broken revisions with half-applied
changes from history but would add unnecessary changes back and forth.
In a case where bad changes could make history confusing editing the
commit messages to add explanations might be useful, but I think this
case is clearly insignificant enough not to matter.