[MPlayer-dev-eng] [PATCH] Zattoo

[Nico Sabbi]

Vladimir Serbinenko wrote:
> I send now the patch supporting logging in. Now the syntax is
> mplayer ztvhttp://<username aka email>:<md5 of your password>:<channel>
> For the list of the channels see my previous mail. As you can see in
> patch it's quite uncomplete (All the FIXMEs). The field I don't know
> much about are named sth[number]. The field serving for identifiing or
> set to constant values are named magick<number>. /*TORES*/ means that
> this field could be something else. In short it just works, nothing more.
> Vladimir 'phcoder' Serbinenko
> 

doing a quick scroll of your patch I noticed that theres not a single 
comment!
A good patch should include descriptions of the working principle and
of the individual functions, otherwise reviewing code 1 month from now
will be impossible.
There are also a lot of printf() that should be replaced with mp_msg().

I also have some questions:
- what demuxer does this stream require?
- are you sure that out http functions can't (at least partly) be reused?
- what's the content of this stream? matroska with some fixed codecs?

-- 
"Without a frontend, mplayer is useless" - someone in mplayer-users