[MPlayer-dev-eng] [PATCH] False positive on pcm in mov samplerate hack

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Mar 7 02:26:46 CET 2007


On Thu, 2006-09-28 at 14:30 -0400, John Koleszar wrote:
> Attached patch fixes playback of a 5512Hz PCM audio track in a mp4 container
> when using the mov demuxer. The lavf demuxer plays the sample correctly.
> 
> demux_mov.c has some hackish code that thinks arbitrarily low sample rates
> (<7000) need to be adjusted. I can't find any samples that actually need the
> fixup, so I can't fix this properly. Does anybody know what this code is trying
> to work around? It's been in the tree practically forever.
> 
> Ripping the whole if() block out and fixing it Right once a broken sample is
> found is IMO a better option, but in the mean time here's a patch that tries to
> prevent these false positives.
> 
> Broken sample here:
> ftp://opensource:opensource@ftp.on2.com/5512hz_pcm.mov

Another user had the same problems and pointed out this forgotten patch.
Applied.




More information about the MPlayer-dev-eng mailing list