[MPlayer-dev-eng] [PATCH] get rid of lots of useless/duplicate code in vo_xv/vo_xvmc

Ivan Kalvachev ikalvachev at gmail.com
Tue Mar 6 15:01:22 CET 2007


2007/3/6, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Feb 18, 2007 at 11:32:04AM +0100, Reimar D?ffinger wrote:
> > see attached patch.
> > Could not see it breaking anything...
>
> Any comments?

Haven't tested it, but it looks OK.

I just don't like foo(void) functions that mess with "globals", but I
guess putting all these variables in struct and passing it around is
too much work for such trivial change ;)

btw how about naming the function calc_drwXY() ?
usually get_something() is expected to return the thing it gets ;)

OK to commit. (at least xvmc part).



More information about the MPlayer-dev-eng mailing list