[MPlayer-dev-eng] [PATCH] double close in ve_vfw.c

Gianluigi Tiesi mplayer at netfarm.it
Tue Mar 6 06:23:24 CET 2007


Reviewing my patch, I've discovered that I made
a possibile double close in the code,
the patch is trivial (attached).

Regards
-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/
-------------- next part --------------
diff -NuBr -x.svn -xhelp_mp.h -xlibdha -x'*.so' -x'*.log' -x'*.a' -x'*.exe' -x'*.o' -xconfigure.log -xconfig.mak -x.cvsignore -xconfig.h -xcodecs.conf.h -xversion.h -x.depend main/libmpcodecs/ve_vfw.c sherpya/libmpcodecs/ve_vfw.c
--- main/libmpcodecs/ve_vfw.c	2007-02-24 06:10:41.396393600 +0100
+++ sherpya/libmpcodecs/ve_vfw.c	2007-03-06 06:20:35.647545600 +0100
@@ -131,7 +131,6 @@
       mp_msg(MSGT_WIN32,MSGL_ERR,"Compressor data %d bytes\n", st.st_size);
       if (!(temp_len = (unsigned int) ICSendMessage(encoder_hic, ICM_SETSTATE, (LPARAM) drvdata, (int) st.st_size))){
         mp_msg(MSGT_WIN32,MSGL_ERR,"ICSetState failed!\n");
-        fclose(fd);
         free(drvdata);
         return NULL;
       }


More information about the MPlayer-dev-eng mailing list