[MPlayer-dev-eng] [PATCH] audio support for avisynth scripts

[Reimar Döffinger]

Hello,
On Sun, Mar 04, 2007 at 01:06:58AM +0100, Gianluigi Tiesi wrote:
> On Thu, Mar 01, 2007 at 01:24:55PM +0100, Reimar D?ffinger wrote:
> > On Tue, Feb 27, 2007 at 06:50:30AM +0100, Gianluigi Tiesi wrote:
> > > pls note that the block that starts with:
> > > 
> > > sh_audio->wf = (WAVEFORMATEX*) malloc(sizeof(WAVEFORMATEX));
> > > 
> > > it's not cosmetics, the new block belong to an else
> > > that is indented +1 rather the old code and anyway the code
> > > is a bit different.
> > 
> > This is still cosmetics according to our definition.
> > I refuse to review this as long as the patch is larger than what a
> > diff -duwBb produces.
> > And yes, attaching would be better, as well as using FFMAX from avutil.h
> > instead of adding a new MAX define.
> > 
> Ok I'll review the code, that is a bit crazy since it's not my code...

Hm. Who should get credit if it's not your code? I fixed some things
already my own way, but the next parts seem good in the patch so I'd
copy them from there...

Greetings,
Reimar Döffinger