[MPlayer-dev-eng] [PATCH 1/4] String handling audit/cleanup

[Alex Beregszaszi]

Hi,

As a general rule I would consider sending such patches in one diff file
for a directory.

in cpudetect.c:

-       sprintf(vendor,"%.4s%.4s%.4s",(char*)(regs+1),(char*)(regs
+3),(char*)(regs+2));
+       snprintf(vendor, sizeof vendor, "%.4s%.4s%.4s",(char*)(regs
+1),(char*)(regs+3),(char*)(regs+2));

change this to sizeof(vendor)

I see this is an issue in other files too.

Regarding unrarlib.c: please send it to upstream too!

--
Alex Beregszaszi