[MPlayer-dev-eng] [PATCH] Inlining realloc_struct

Zuxy Meng zuxy.meng at gmail.com
Fri Mar 2 03:41:48 CET 2007


Hi,

2007/3/2, Rich Felker <dalias at aerifal.cx>:
> On Fri, Mar 02, 2007 at 10:09:15AM +0800, Zuxy Meng wrote:
> > Hi,
> >
> > I guess functions in header files should be in inline?
>
> No particular reason it should or shouldn't be inline. In fact the
> inline keyword is supposed to be something of a no-op - the compiler
> should pick to inline or not based on which is better. I have no
> major objection to this patch but it's not really needed either.

One benefit is that it avoids a "unused after use" warning:-)

> Not inlining might save a small amount of space and should not affect
> performance.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list