[MPlayer-dev-eng] Re: [PATCH] Play AMR over rtsp
Carl Eugen Hoyos
cehoyos at ag.or.at
Fri Mar 2 01:00:17 CET 2007
> > is it a joke? 1 byte of extradata?
> > who's the idiot that designed this crap?
Allow me to point you to RFC 3267, sec. 5.3 (which I, of course, did not read; I
read vlc and live555 sources).
> > and why is it prepended to the demux_packet data rather than being
> > copied to sh_audio->codecdata?
> uhm, after re-reading the code I realized that the 1 byte wouldn't fit
> as extradata,
> cause it's not global (or maybe it's constant but not evident? ).
> Can anyone explain what's the purpose of
It seems to contain the first byte of the audioframe;-)
Audio cannot be decoded without it.
> and if it's constant or variable?
It is constant (but different) for the four teststreams I have, but unknown
before the first audioframe is received.
> For sure prepending it to the payload doesn't look nice to me
Please also look at the patch Choon Yoong Goh sent, perhaps you prefer it:
Thanks for reviewing, Carl Eugen
More information about the MPlayer-dev-eng