[MPlayer-dev-eng] [PATCH] reset vf error before codec init

[Reimar Döffinger]

Hello,
On Thu, Mar 01, 2007 at 04:36:44PM +0200, Ivan Kalvachev wrote:
> 2007/3/1, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> >On Sun, Feb 25, 2007 at 08:48:03PM +0100, Reimar D?ffinger wrote:
> >> when multiple codecs are tried (mpegpes and mpeg12 was the problematic
> >> case here), init can incorrectly fail with "FATAL: Could not initialize
> >> video filters (-vf) or video output (-vo).".
> >> The reason is that the first codec did fail due to some filter problems,
> >> while the second one did not yet config the vo e.g. because it must wait
> >> for a keyframe before it can do that.
> >> Is attached patch okay?
> >
> >Comments? If not I will apply soon.
> 
> Hum
> the init_video() function starts with
>  sh_video->vf_inited=0;
> maybe the your zeroing should not be optional? (not that it matters,
> vf_inited is only checked for negative error value)

Positive values are not error values. I am not 100% sure, but setting to
0 when it is > 0 might cause the filters not to be properly freed when
reiniting next time.
Probably either way works, but only < 0 causes troubles so far.

Greetings,
Reimar Döffinger